Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_reconcile_analytic_tag: Avoid error when accessing the reconciliation view #766

Merged

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Dec 17, 2024

Avoid error when accessing the reconciliation view

res[index]["manual_analytic_tag_ids"] = [(6, 0, line.analytic_tag_ids.ids)]
IndexError: list index out of range

Steps to reproduce the error:

  • Go to Accounting Dashboard
  • Click on the Reconcile X items button of the bank journal

Please @chienandalu can you review it?

@Tecnativa

…reconciliation view

Steps to reproduce the error:
- Go to Accounting Dashboard
- Click on the Reconcile X items button of the bank journal
@pedrobaeza pedrobaeza added this to the 16.0 milestone Dec 17, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index shouldn't increase if the balance is zero.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-766-by-pedrobaeza-bump-patch, awaiting test results.

@victoralmau
Copy link
Member Author

Example of the error (added to the description of the PR).
ejemplo

@pedrobaeza
Copy link
Member

The error is not put on the commit message. Please take it into account for the next time. You always have to put the error.

@OCA-git-bot OCA-git-bot merged commit 3ed4a8f into OCA:16.0 Dec 17, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fa6d728. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-fix-account_reconcile_analytic_tag-misc branch December 17, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants