Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][ADD] account_reconcile_payment_order #722

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

etobella
Copy link
Member

@etobella etobella commented Oct 2, 2024

@alexis-via I think you will enjoy this one 😉

Still some work to do on documentation, but we have something to start

@etobella etobella force-pushed the 16.0-account_reconcile_order branch from 54e2dff to 0ed72e5 Compare October 2, 2024 07:00
@etobella
Copy link
Member Author

etobella commented Oct 9, 2024

image
How it is seen

@etobella etobella force-pushed the 16.0-account_reconcile_order branch 2 times, most recently from df4bec8 to 10a5cd4 Compare October 9, 2024 11:52
@etobella etobella force-pushed the 16.0-account_reconcile_order branch from 10a5cd4 to e890dc7 Compare October 9, 2024 13:28
@etobella
Copy link
Member Author

etobella commented Oct 9, 2024

I even added a post init hook in order to generate data.

@alexis-via WDYT about it?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 9, 2024
@pedrobaeza
Copy link
Member

I told Alexis my take on this, and I don't think we should go this way.

My idea is to enable groups on the list view, and adding a button on the group headers to add the entire group lines in the current reconciliation. For payment orders, we will only need to group by the proper fields (and maybe add a related stored field in aml). This is also more versatile for other kind of mass additions.

@etobella
Copy link
Member Author

etobella commented Oct 9, 2024

@pedrobaeza You are suggesting something like this?
image

@pedrobaeza
Copy link
Member

Well, more or less, but the group feature should be available on that "mini-view", and the button "ADD ALL" should be in each group. There are similar action buttons on v15 journal views (that are grouped by entry in this case):

imagen

@etobella
Copy link
Member Author

etobella commented Oct 9, 2024

I checked your proposal and it might work partially, but there are some related issues:

It is not filtering properly. I mean, when you press the button, you are not getting data from all the childs, you are processing the data of the record.

Let's put an examples

  • We group by Payment Order and Select one, it will work perfectly 👍
  • We group by Payment Order, filter by a Partner and select one, it will select all the lines of the payment order. It will not get the proper data. 👎

Also, we will not be able to split data properly on a payment order if multiple dates exist.

So, IMO, it is not feasible using only standard odoo functionality 🤔

BTW, it looked as expected (I made the test using Journal, but you can see how it would look like):

image

@pedrobaeza
Copy link
Member

I understand the issue you have found, but I think we can provide a combination:

  • You can stack groups, so that's give more granularity.
  • If the group is missing any element because a filter, don't show the button.
  • Have the button on the top also for including the "visible items" as you have it at the beginning.
  • Include favorites for saving groups (or maybe provide them pre-fixed).

With all of this, we will have enough tools for doing reconciliation in batches. A small glue module providing the fields to group will be the only need on that matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants