Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] account_reconciliation_widget: Avoid unbalanced foreign currency reconciliations + exclude own amls in reconcile models propositions #633

Merged
merged 2 commits into from
Feb 24, 2024
Merged

[15.0][FIX] account_reconciliation_widget: Avoid unbalanced foreign currency reconciliations + exclude own amls in reconcile models propositions #633

merged 2 commits into from
Feb 24, 2024

Commits on Feb 24, 2024

  1. [FIX] account_reconciliation_widget: Avoid unbalanced foreign currenc… 

    …y reconciliations

When having a statement line in a foreign currency, each resulting
journal item computes the debit/credit amount from the foreign currency
rate, and then rounding the result to company currency digits.

There's a chance in this process that the journal entry final balance
is not 0 summing the rounded balances in company currency.

For fixing this, there can be several strategies, like creating an
extra journal item for the difference, but I have opted for removing
the difference in the latest counterpart aml, so no extra noise and
no need of account decision algorithm for this extra move.

As currency amounts are correct and are the ones used in reconciliation,
there won't be any problem adjusting this amount.

TT45568
    @pedrobaeza
    pedrobaeza committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    48fd1cd View commit details
    Browse the repository at this point in the history

  2. [FIX] account_reconciliation_widget: Don't suggest own journal items 

    When getting propositions from the reconcile models, we should
explicitly exclude the amls of the bank statement lines.

If not, we can get a situation where the journal item of the bank
statement line is proposed to itself.

TT45568
    @pedrobaeza
    pedrobaeza committed Feb 24, 2024
    Configuration menu
    Copy the full SHA
    540a667 View commit details
    Browse the repository at this point in the history