-
-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][IMP] account_mass_reconcile: Add 'oldest move line' option on reconc… #604
[16.0][IMP] account_mass_reconcile: Add 'oldest move line' option on reconc… #604
Conversation
b5fa058
to
c46f445
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add tests to cover the oldest use case.
Also, i wouldn't change last_date
to most_recent_date
.
c46f445
to
54eec0f
Compare
Tests have been added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ocabot merge minor |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 94813f7. Thanks a lot for contributing to OCA. ❤️ |
…ile option
Oldest move line date option is added for write off move date
Additionally, "Most recent move line" and "Oldest move line" are used for choosing the move which is going to get reconciled if more than one is available.