Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_mass_reconcile: Add 'oldest move line' option on reconc… #604

Merged

Conversation

aritzolea
Copy link
Contributor

…ile option

Oldest move line date option is added for write off move date

Additionally, "Most recent move line" and "Oldest move line" are used for choosing the move which is going to get reconciled if more than one is available.

@aritzolea aritzolea force-pushed the 16.0-imp-account_mass_reconcile-oldest_date branch from b5fa058 to c46f445 Compare October 24, 2023 06:19
Copy link

@ljsalvatierra-factorlibre ljsalvatierra-factorlibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests to cover the oldest use case.

Also, i wouldn't change last_date to most_recent_date.

@aritzolea aritzolea force-pushed the 16.0-imp-account_mass_reconcile-oldest_date branch from c46f445 to 54eec0f Compare October 25, 2023 08:21
@aritzolea
Copy link
Contributor Author

Please add tests to cover the oldest use case.

Also, i wouldn't change last_date to most_recent_date.

Tests have been added

Copy link

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronHForgeFlow
Copy link

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-604-by-AaronHForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 153767d into OCA:16.0 Oct 26, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 94813f7. Thanks a lot for contributing to OCA. ❤️

@aritzolea aritzolea deleted the 16.0-imp-account_mass_reconcile-oldest_date branch December 14, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants