[14.0][FIX] account_reconciliation_widget: Avoid unbalanced foreign currency reconciliations + exclude own amls in reconcile models propositions #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y reconciliations When having a statement line in a foreign currency, each resulting journal item computes the debit/credit amount from the foreign currency rate, and then rounding the result to company currency digits. There's a chance in this process that the journal entry final balance is not 0 summing the rounded balances in company currency. For fixing this, there can be several strategies, like creating an extra journal item for the difference, but I have opted for removing the difference in the latest counterpart aml, so no extra noise and no need of account decision algorithm for this extra move. As currency amounts are correct and are the ones used in reconciliation, there won't be any problem adjusting this amount. TT45568
pedrobaeza
force-pushed
the
14.0-fix-account_reconciliation_widget-foreign_currency_unbalanced
branch
from
8c9e613
to
2a1171d
Compare
When getting propositions from the reconcile models, we should explicitly exclude the amls of the bank statement lines. If not, we can get a situation where the journal item of the bank statement line is proposed to itself. TT45568
|
Added an extra commit for a discovered situation testing the other patch: the journal item of a bank statement line can be proposed to itself in the reconciliation widget. This patch also requires a patch in Odoo: odoo/odoo#139419 |
pedrobaeza
changed the title
pedrobaeza
requested review from
victoralmau and
chienandalu
and removed request for
sergio-teruel and
carlosdauden
chienandalu
approved these changes
Nov 6, 2023
victoralmau
approved these changes
Nov 6, 2023
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2548da4. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
14.0-fix-account_reconciliation_widget-foreign_currency_unbalanced
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a statement line in a foreign currency, each resulting journal item computes the debit/credit amount from the foreign currency rate, and then rounding the result to company currency digits.
There's a chance in this process that the journal entry final balance is not 0 summing the rounded balances in company currency.
For fixing this, there can be several strategies, like creating an extra journal item for the difference, but I have opted for removing the difference in the latest counterpart aml, so no extra noise and no need of account decision algorithm for this extra move.
As currency amounts are correct and are the ones used in reconciliation, there won't be any problem adjusting this amount.
@Tecnativa TT45568