[16.0][FIX] account_reconcile_oca: UnboundLocalError: local variable …

[astirpe]

…'balance' referenced before assignment

Fixes #592, by applying the patch proposed here: odoo/odoo#123626

This is a quick&dirty fix, waiting for better ideas on how to fix it.

[OCA-git-bot]

Hi @etobella,
some modules you are maintaining are being modified, check this out!

[etobella]

Can you squash your commits?

[ThijsvOers]

Tested this and it works. Please merge this fix as soon as possible since other modules are depending on this fix (and they are failing now). TIA

[etobella]

I don't feel comfortable with this change. Which is the definition of the model that is giving you this error?

[astirpe]

@etobella this is something you fixed when porting the module to V16: #500 (comment)

But then the bug re-appeard after your PR: #580

So the problem is standard odoo method _get_write_off_move_lines_dict() that is bugged. Model is "account.reconcile.model". The fix I applied is this one: https://github.com/odoo/odoo/pull/123626/files . Not sure I answered your question?

[pedrobaeza]

Don't make a verbatim copy of the method, but overwrite _get_write_off_move_lines_dict and add/patch what you need.

[astirpe]

This is a quick&dirty fix and i don't think I will have time to change it. If anyone will take over and propose a better solution I will be happy. Shall I close this one?

[ACheung-FactorLibre]

Hi,
If Odoo merges this FIX: odoo/odoo#154551, the error will be fixed and it won't be necessary to ovewrite any funcion.

[astirpe]

Thank you @ACheung-FactorLibre