Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_reconcile_oca: only store info on unreconciled items #585

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

etobella
Copy link
Member

@etobella etobella commented Sep 5, 2023

#584

The idea is to clear the data after reconciliation (we need to keep until it is reconciled in order to ensure that we can navigate without loosing everything).
Still missing a migration script in order to get out the old data.

WDYT @pedrobaeza ?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Sep 5, 2023
@pedrobaeza pedrobaeza changed the title [IMP] account_reconcile_oca: only store info on unreconciled items [16.0][IMP] account_reconcile_oca: only store info on unreconciled items Sep 5, 2023
@pedrobaeza
Copy link
Member

Now I understand more the reason for storing some "transient" information: you want to resume a half-baked reconciliation. That's not the usual case, but it can be useful. But ignoring that information if not needed is something reasonable.

@etobella
Copy link
Member Author

etobella commented Sep 6, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-585-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

@etobella The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-585-by-etobella-bump-patch:16.0 failed with output:

To https://github.com/OCA/account-reconcile
 ! [remote rejected]   16.0-ocabot-merge-pr-585-by-etobella-bump-patch -> 16.0 (cannot lock ref 'refs/heads/16.0': is at a54c9254628620c695de2cdc2aeb374e95da3c6a but expected 99fb0b5fc5dea09c9e6f0a0409e6d6b4152a3fab)
error: failed to push some refs to 'https://***@github.com/OCA/account-reconcile'

@OCA-git-bot OCA-git-bot merged commit 7b39b97 into OCA:16.0 Sep 6, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at a54c925. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants