[12.0][FIX] stock_account: Correct order in candidates_receipt search for FIFO valuation
#1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yostashiro
reviewed
May 15, 2024
There was a problem hiding this comment.
@kanda999 Can you please add a short description in the commit title?
…IFO valuation When decreasing `qty_done` in an outgoing stock move, the search query for `candidates_receipt` was ordering by `date` in ascending order, resulting in the selection of the oldest record instead of the most recent one. This commit changes the order to `date desc, id desc` to ensure the most recent record is selected, as intended by the comments in the write method.
kanda999
force-pushed
the
12.0-fix-stock_account
branch
from
fe8b9fc
to
02fb389
Compare
AungKoKoLin1997
approved these changes
Jul 9, 2024
|
I think this behavior change in such an old version is too much to be accepted, unless this is something already changed in later versions. |
|
I'm not sure the reasoning behind not accepting the change because it is an older version. I have made the code modification based on the comment written in the method: "If the move is outgoing and the user decreases qty_done, we either increase the last receipt candidate if one is found or we decrease the value with the last fifo price." In the future, users of OCB 12.0 might encounter this strange behavior. In fact, one of our customers has already experienced this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of issue/feature this PR addresses:
Incorrectly orders the search results by date (a datetime field) in ascending order and then by id in descending order.
This results in the selection of the oldest record instead of the last one.
Current behavior before PR:
The search query extracts the oldest stock.move record instead of the last one when updating the value and remaining quantity in FIFO cost method during the decrease of qty_done in an outgoing move.
Desired behavior after PR is merged:
The search query correctly extracts the last stock.move record by ordering the results first by date in descending order.
@qrtl QT4562
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr