[12.0][FIX] base: postgres subprocess error when dumping database #1211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Odoo is installed with the latest version of the PostgreSQL client (postgres-client or postgres-client-16) and running in Docker (possibly other environments as well but not reproduced so far), executing
pg_dump
viaexec_pg_command
fails withThis seems to be because
os.devnull
is being opened in read mode which is incorrect (as it's written to). It's not entirely clear if olderpg_dump
simply ignored the non-writable stdout or if docker adds some restrictions which cause the failure.Either way this can be solved by either opening
os.devnull
in write mode or switching to theDEVNULL
constant. While the function is deprecated in 16.0 (7f14631) and removed in master (ae3056f) the latter is not a huge change and it a touch cleaner.fixes odoo#139687
closes odoo#143198