-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed syntax errors in api-with-examples.yaml #2036
Conversation
Seems inline YAML spanning multiple lines was not officially supported in symfony/yaml until version 4.4: symfony/symfony#34805 (comment) (there is also a bug with parsing these in the current version, which is reported in the linked issue) |
close OAI#2036
Tried latest version of files with
|
@cebe @mabar Can we not use a YAML library which supports the whole of the 1.2 spec and uses the official YAML test suite? If that means ditching PHP from the proposed GitHub actions, then so be it, and here's a vote to use Javascript instead as per the existing (and a couple of proposed) Travis CI jobs. |
As far as I see there is no PHP library that matches the criteria. Most stable and supported library is the one we are using right now. However the version I am using in the github action works well with our current set of example YAML files. The issue shown above in I suggest to keep the current implementation now (as it is working) and replace it with a javascript implementation when someone has time to work on that. |
Closing as this is a duplicate of #1914 |
With original, php implementation of yaml symfony/yaml I got some syntax errors. This PR fixes them.
Online parsers which consider current file valid:
Online parsers which reports error:
With proposed changes is file valid for all of them