Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing tests #69

Closed
wants to merge 2 commits into from
Closed

Fix failing tests #69

wants to merge 2 commits into from

Conversation

phil-r
Copy link

@phil-r phil-r commented Feb 12, 2018

No description provided.

@MoOx
Copy link
Collaborator

MoOx commented Feb 12, 2018

Master didn't fail when it was build (I know it's 10 month ago, but semver...?).
Could you explain the motivation or this PR?

@phil-r
Copy link
Author

phil-r commented Feb 12, 2018

Hi @MoOx , for me latest master fails with

TypeError: Cannot read property 'lastVersions' of undefined

Also I can't find such api(browserslist.queries.lastVersions.select(1)) in browserslist

@phil-r
Copy link
Author

phil-r commented Feb 12, 2018

@MoOx Here is the change that removed queries from browserslist object: browserslist/browserslist@640b62f#diff-168726dbe96b3ce427e7fedce31bb0bcL465

@MoOx
Copy link
Collaborator

MoOx commented Feb 12, 2018

Can you please bump browserlist version to make this PR complete? Thanks!

@phil-r
Copy link
Author

phil-r commented Feb 12, 2018

@MoOx done 😉

@Nyalab
Copy link
Owner

Nyalab commented Mar 2, 2018

this was fixed by #71, thanks for your time though

@Nyalab Nyalab closed this Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-r @MoOx @Nyalab