Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix patch #32

Merged
merged 2 commits into from
Aug 10, 2023
Merged

Bug fix patch #32

merged 2 commits into from
Aug 10, 2023

Conversation

henrique-borba
Copy link
Member

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix NDArray_Fill method memory error
Fixed isGPU method to return value correctly

What is the current behavior? (You can also link to an open issue here)

NDArray_Fill was causing the device to release memory prematurely.

[z=](php: ./src/buffer.c:81: buffer_get: Assertion `MAIN_MEM_STACK.buffer[uuid] != NULL' failed.)

NDArray_isGPU was returning incorrect values.

@henrique-borba henrique-borba added the bug Something isn't working label Aug 10, 2023
@henrique-borba henrique-borba added this to the 0.2.0 milestone Aug 10, 2023
@henrique-borba henrique-borba self-assigned this Aug 10, 2023
@henrique-borba henrique-borba changed the title Bug fix patches Bug fix patche Aug 10, 2023
@henrique-borba henrique-borba changed the title Bug fix patche Bug fix patch Aug 10, 2023
@henrique-borba henrique-borba merged commit 7c2184a into main Aug 10, 2023
@henrique-borba henrique-borba deleted the fix/bug_fix_patch branch August 10, 2023 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

1 participant