fix(tokio): attempt to decode from internal state even if nothing was read #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not expected if you just read Same as #123 there is no test, but Delta Chat will serve as a downstream test once this is merged. deltachat/deltachat-core-rust#5990 has an extensive test suite and it passes expect for cargo-deny complaining about git dependency. |
link2xt
force-pushed
the
link2xt/miniz_oxide-consumes-all-input
branch
3 times, most recently
from
df982ea
to
cdc1ed9
Compare
link2xt
changed the title
… read Unlike zlib, miniz_oxide consumes data into internal state even if there is not enough space in the output buffer. Next time poll_fill_buf() is called we should try to decode from internal state even if no new compressed data was read. This change is a port of fix <Nullus157#123> (commit Nullus157@22ed0ac) from `futures` to `tokio`.
link2xt
force-pushed
the
link2xt/miniz_oxide-consumes-all-input
branch
from
b33a42c
to
ed83d67
Compare
This was referenced Oct 9, 2024
|
cc @NobodyXu This is ready for review and I am not going to change this further. |
NobodyXu
approved these changes
Oct 10, 2024
|
Thanks, that looks good to me |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike zlib, miniz_oxide consumes data into internal state
even if there is not enough space in the output buffer.
Next time poll_fill_buf() is called we should try
to decode from internal state even if no new compressed data
was read.
This change is a port of fix #123 (commit 22ed0ac) from
futurestotokio.