Fix compressing large chunks #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fairingrey |
|
Looks good. I think it makes a lot more sense now reading through the code. I will have to refactor #10 but it shouldn't take too long, I imagine. |
Flushing previously didn't guarantee that it would flush out the entire data. As part of this the flate and gzip implementations were refactored to a state machine as I believe this makes them much more understandable, especially the gzip implementation.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Flushing previously didn't guarantee that it would flush out the entire
data.
As part of this the flate and gzip implementations were refactored to a
state machine as I believe this makes them much more understandable,
especially the gzip implementation.
Motivation and Context
This should fix the issue mentioned at http-rs/tide#194 (comment)
How Has This Been Tested?
New tests added.
Types of changes
Checklist: