Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the copy button (when copying snippets) #1817

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

NullVoxPopuli
Copy link
Owner

The copy button previously included the copy menu (but not the copy button).

This work now also excludes the copy menu.

Copy link

stackblitz bot commented Sep 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Project Preview URL1 Manage
Limber https://fix-copy-button.limber-glimdown.pages.dev on Cloudflare
Tutorial https://fix-copy-button.limber-glimmer-tutorial.pages.dev on Cloudflare

Logs

Footnotes

  1. if these branch preview links are not working, please check the logs for the commit-based preview link. There is a character limit of 28 for the branch subdomain, as well as some other heuristics, described here for the sake of implementation ease in deploy-preview.yml, that algo has been omitted. The URLs are logged in the wrangler output, but it's hard to get outputs from a matrix job.

@NullVoxPopuli NullVoxPopuli merged commit 2ba59fe into main Sep 4, 2024
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the fix-copy-button branch September 4, 2024 22:51
@github-actions github-actions bot mentioned this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant