Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@embroider/vite doesn't support type imports? #1716

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

NullVoxPopuli
Copy link
Owner

Blockers:

  • @embroider/vite does not know how to handle type imports
      VITE v5.2.3  ready in 6261 ms
    
      ➜  Local:   http://localhost:4201/
      ➜  Network: use --host to expose
      ➜  press h + enter to show help
    Error:   Failed to scan for dependencies from entries:
      <repo>/apps/repl/node_modules/.embroider/rewritten-app/index.html
    <repo>/apps/repl/node_modules/.embroider/rewritten-app/tests/index.html
    
      ✘ [ERROR] <repo>/apps/repl/node_modules/.embroider/rewritten-app/services/editor.ts: Unexpected token, expected "from" (9:12)
    
       7 | import { FileURIComponent } from 'limber/utils/editor-text';
       8 |
    >  9 | import type RouterService from '@ember/routing/router-service';
         |             ^
      10 | import type { Format } from 'limber/utils/messaging';
      11 |
      12 | export default class EditorService extends Service { [plugin embroider-esbuild-resolver]
    
        node_modules/.embroider/rewritten-app/assets/limber.js:8:22:
          8 │ import * as _i40 from "limber/services/editor.ts";
            ╵                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
      This error came from the "onLoad" callback registered here:
    
        ../../node_modules/.pnpm/@embroider+vite@0.2.1-unstable.bac2415_@embroider+core@3.4.6-unstable.bac2415_@glint+template@1.3.0_vite@5.2.3/node_modules/@embroider/vite/src/esbuild-resolver.js:95:18:
          95 │             build.onLoad({ filter: /\.[jt]s$/ }, ({ path, namespac...
             ╵                   ~~~~~~
    
        at setup (<.pnpm>/@embroider+vite@0.2.1-unstable.bac2415_@embroider+core@3.4.6-unstable.bac2415_@glint+template@1.3.0_vite@5.2.3/node_modules/@embroider/vite/src/esbuild-resolver.js:95:19)
        at handlePlugins (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:1293:21)
        at buildOrContextImpl (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:979:5)
        at Object.buildOrContext (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:788:5)
        at <.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:2224:68
        at new Promise (<anonymous>)
        at Object.context (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:2224:27)
        at Object.context (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:2048:58)
        at prepareEsbuildScanner (file://<.pnpm>/vite@5.2.3/node_modules/vite/dist/node/chunks/dep-Bh2jsKCM.js:51301:26)
    
    
    ✘ [ERROR] <repo>/apps/repl/node_modules/.embroider/rewritten-app/utils/editor-text.ts: Unexpected token, expected "," (9:30)
    
       7 | import { compressToEncodedURIComponent } from 'lz-string';
       8 |
    >  9 | import { fileFromParams, type Format, formatFrom } from 'limber/utils/messaging';
         |                               ^
      10 |
      11 | import type RouterService from '@ember/routing/router-service';
      12 | [plugin embroider-esbuild-resolver]
    
        node_modules/.embroider/rewritten-app/assets/limber.js:10:22:
          10 │ import * as _i60 from "limber/utils/editor-text.ts";
             ╵                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    
      This error came from the "onLoad" callback registered here:
    
        ../../node_modules/.pnpm/@embroider+vite@0.2.1-unstable.bac2415_@embroider+core@3.4.6-unstable.bac2415_@glint+template@1.3.0_vite@5.2.3/node_modules/@embroider/vite/src/esbuild-resolver.js:95:18:
          95 │             build.onLoad({ filter: /\.[jt]s$/ }, ({ path, namespac...
             ╵                   ~~~~~~
    
        at setup (<.pnpm>/@embroider+vite@0.2.1-unstable.bac2415_@embroider+core@3.4.6-unstable.bac2415_@glint+template@1.3.0_vite@5.2.3/node_modules/@embroider/vite/src/esbuild-resolver.js:95:19)
        at handlePlugins (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:1293:21)
        at buildOrContextImpl (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:979:5)
        at Object.buildOrContext (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:788:5)
        at <.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:2224:68
        at new Promise (<anonymous>)
        at Object.context (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:2224:27)
        at Object.context (<.pnpm>/esbuild@0.20.2/node_modules/esbuild/lib/main.js:2048:58)
        at prepareEsbuildScanner (file://<.pnpm>/vite@5.2.3/node_modules/vite/dist/node/chunks/dep-Bh2jsKCM.js:51301:26)
    

Copy link

stackblitz bot commented Mar 23, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Mar 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants