Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #62

Merged
merged 9 commits into from
Oct 6, 2022
Merged

Refactor #62

merged 9 commits into from
Oct 6, 2022

Conversation

Alexejhero
Copy link
Member

@Alexejhero Alexejhero commented Oct 3, 2022 •
edited
Loading

The refactorer strikes again!!

Changes made in this pull request

  • Overall cleanup in the project structure to make it less confusing for newer contributors and make it easier to add new features without throwing them in the project in random places.
    • Classes are now grouped by the main feature they represent, followed by sub-feature or class type.
      • For example, Networking/Rpcs contains all of the rpc-related classes
      • GUI/Extensions contains extension methods for Unity UI, like Rect or Texture-related stuff
    • Cleaned up the "extension" files which, even though they were supposed to be grouped by category, seemed to have been scrambled by someone
    • Cleaned up the "patches" files which also contained extensions and random monobehaviours
  • Updated BepInEx and GameLibs dependencies

@Alexejhero Alexejhero marked this pull request as ready for review October 3, 2022 15:15
simonkellly
simonkellly approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@simonkellly simonkellly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good changes

@Alexejhero
Bump dependencies
eb65452
@Alexejhero
Refactor project structure
b0682a8 
Use not null type check instead of null check pattern

Update namespaces
@Alexejhero
Show props files in solution view
b48fdd8
@edqx
Copy link
Contributor

edqx commented Oct 3, 2022

Very good changes
AlexejheroYTB reacted with thumbs up emoji
natsu-k reacted with

Alexejhero
Alexejhero commented Oct 6, 2022
View reviewed changes
Reactor/Networking/Rpc/CustomRpcManager.cs Show resolved Hide resolved
Reactor/Networking/Rpc/CustomRpcManager.cs Outdated Show resolved Hide resolved
Reactor/Patches/Fixes/CursorPosPatch.cs Outdated Show resolved Hide resolved
Reactor/Utilities/RegionInfoWatcher.cs Outdated Show resolved Hide resolved
Reactor/Patches/QOL/BetterGuestPatch.cs Outdated Show resolved Hide resolved
@js6pak js6pak changed the title Refactor namespace organization and project structure for v2 release Refactor Oct 6, 2022
@js6pak js6pak merged commit b7971d3 into NuclearPowered:v2 Oct 6, 2022
@Alexejhero Alexejhero mentioned this pull request Oct 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js6pak js6pak js6pak left review comments

@simonkellly simonkellly simonkellly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexejhero @edqx @simonkellly @js6pak