-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CODEOWNERS to docs PRs #2836
Conversation
Docs Build status updates of commit f37f292: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
.github/CODEOWNERS
Outdated
# the repo. Unless a later match takes precedence, | ||
# review when someone opens a pull request. | ||
# For more on how to customize the CODEOWNERS file - https://help.github.com/en/articles/about-code-owners | ||
* @NuGet/nuget-client @NuGet/nuget-pm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the nuget.org section of the docs should go to the server team, not the client team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added following clauses in the latest commit. I didn't find @NuGet/nuget-server team like @NuGet/nuget-client. AFAIK the following settings notifies both client and server teams for changes related to either /docs/nuget-org/
or /docs/policies/
directory. Please let me know what you think.
# @NuGet/core-team owns any file in the `/docs/nuget-org/` directory
# in the root of your repository and any of its subdirectories.
/docs/nuget-org/ @NuGet/core-team
# @NuGet/core-team owns any file in the `/docs/policies/` directory
# in the root of your repository and any of its subdirectories.
/docs/policies/ @NuGet/core-team
I can also make @NuGet/core-team as default reviewers for all the files and then specify the exact locations in the docs that are owned by client team to notify @NuGet/nuget-client team. As per GitHub docs the last team matching the criteria will be notified. In either case, client team members will be notified because of lack of separate team list for server team members.
Docs Build status updates of commit 074362c: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
Docs Build status updates of commit 36223a6: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this, but I'd wait on @zivkan before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the comments provide much value, but it's not a long file.
* document The parameter is incorrect behavior (#2800) * document The parameter is incorrect behavior * Add a note/tip instead of bold. Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Add a dedicated page for props and targets (#2807) * Document NU1802 and NU1803 (#2816) * Add list in Normalized version numbers (#2818) Fix #2817 * Clarify headline of section about projects without any package dependencies (#2812) * Add issue management bots (#2825) * Fix formatting typo in CPM (#2832) * Add Gitea to NuGet hosting solutions (#2828) * Add Gitea to NuGet hosting solutions * Use Gitea project URL * Update NU1100.md (#2829) NU1100 may also be caused by the lack of a NuGet configura * Updates to ms.date values based on file history (#2831) * Updates to ms.date values based on file history * edit * fixed year * Alphabetize nuget list (#2837) * Improve NU1100 (#2838) * Add CODEOWNERS to docs PRs (#2836) * Release notes for 6.3 (#2834) * release notes for 6.3 Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: andrei <andreiepure@users.noreply.github.com> Co-authored-by: riQQ <riQQ@users.noreply.github.com> Co-authored-by: Drew Noakes <git@drewnoakes.com> Co-authored-by: John Olheiser <john+github@jolheiser.com> Co-authored-by: Nestor Waldyd <nwaldyd@yahoo.co.uk> Co-authored-by: Mike Jones <mikejo@microsoft.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com>
* Change link for pre-release guidance * Update release notes images * End of May 2022 Live Update (#2763) * June 2022 docs merge (#2783) * Add 5.9 release notes (#2780) * Add 6.0.2 release notes (#2774) * Add 5.11 release notes (#2775) * Add 5.7 release notes (#2776) * Add 4.9 release notes (#2777) * Add 5.2 release notes (#2778) * Merge main to live (#2808) * document The parameter is incorrect behavior (#2800) * document The parameter is incorrect behavior * Add a note/tip instead of bold. Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Add a dedicated page for props and targets (#2807) Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Updates to ms.date values based on file history * edit * fixed year * August Docs Live Merge (#2840) * document The parameter is incorrect behavior (#2800) * document The parameter is incorrect behavior * Add a note/tip instead of bold. Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Add a dedicated page for props and targets (#2807) * Document NU1802 and NU1803 (#2816) * Add list in Normalized version numbers (#2818) Fix #2817 * Clarify headline of section about projects without any package dependencies (#2812) * Add issue management bots (#2825) * Fix formatting typo in CPM (#2832) * Add Gitea to NuGet hosting solutions (#2828) * Add Gitea to NuGet hosting solutions * Use Gitea project URL * Update NU1100.md (#2829) NU1100 may also be caused by the lack of a NuGet configura * Updates to ms.date values based on file history (#2831) * Updates to ms.date values based on file history * edit * fixed year * Alphabetize nuget list (#2837) * Improve NU1100 (#2838) * Add CODEOWNERS to docs PRs (#2836) * Release notes for 6.3 (#2834) * release notes for 6.3 Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: andrei <andreiepure@users.noreply.github.com> Co-authored-by: riQQ <riQQ@users.noreply.github.com> Co-authored-by: Drew Noakes <git@drewnoakes.com> Co-authored-by: John Olheiser <john+github@jolheiser.com> Co-authored-by: Nestor Waldyd <nwaldyd@yahoo.co.uk> Co-authored-by: Mike Jones <mikejo@microsoft.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com> * November / NuGet 6.4 Merge (#2934) * In all content, remove (#2920) ms.prod = nuget Replace with ms.service = nuget Co-authored-by: Docs Allowlist Management <docs-allowlist-mgmt@microsoft.com> * Update VS extensibility docs (#2929) * Document various log codes (#2933) Documenting: NU1008, NU1009, NU1010, NU1011, NU1109, NU1402, NU1403, NU5042, NU5049 * Release notes for 6.4 (#2926) * Suggest a more generally appropriate import tag (#2932) * Suggest a more generally appropriate import tag Co-authored-by: opbld17 <opbld17@microsoft.com> Co-authored-by: Docs Allowlist Management <docs-allowlist-mgmt@microsoft.com> Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: Jean-Pierre Briedé <jebriede@microsoft.com> Co-authored-by: Andrew Arnott <andrewarnott@gmail.com> * Ms.date update --------- Co-authored-by: Christopher R. Gill <christopher.gill@microsoft.com> Co-authored-by: Jon Douglas <jodou@microsoft.com> Co-authored-by: Christopher R. Gill <chrisraygill@gmail.com> Co-authored-by: Joel Verhagen <jver@microsoft.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: andrei <andreiepure@users.noreply.github.com> Co-authored-by: riQQ <riQQ@users.noreply.github.com> Co-authored-by: Drew Noakes <git@drewnoakes.com> Co-authored-by: John Olheiser <john+github@jolheiser.com> Co-authored-by: Nestor Waldyd <nwaldyd@yahoo.co.uk> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com> Co-authored-by: opbld17 <opbld17@microsoft.com> Co-authored-by: Docs Allowlist Management <docs-allowlist-mgmt@microsoft.com> Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com> Co-authored-by: Jean-Pierre Briedé <jebriede@microsoft.com> Co-authored-by: Andrew Arnott <andrewarnott@gmail.com> Co-authored-by: Your Name <you@example.com>
* Change link for pre-release guidance * Update release notes images * End of May 2022 Live Update (#2763) * June 2022 docs merge (#2783) * Add 5.9 release notes (#2780) * Add 6.0.2 release notes (#2774) * Add 5.11 release notes (#2775) * Add 5.7 release notes (#2776) * Add 4.9 release notes (#2777) * Add 5.2 release notes (#2778) * Merge main to live (#2808) * document The parameter is incorrect behavior (#2800) * document The parameter is incorrect behavior * Add a note/tip instead of bold. Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Add a dedicated page for props and targets (#2807) Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Updates to ms.date values based on file history * edit * fixed year * August Docs Live Merge (#2840) * document The parameter is incorrect behavior (#2800) * document The parameter is incorrect behavior * Add a note/tip instead of bold. Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> * Add a dedicated page for props and targets (#2807) * Document NU1802 and NU1803 (#2816) * Add list in Normalized version numbers (#2818) Fix #2817 * Clarify headline of section about projects without any package dependencies (#2812) * Add issue management bots (#2825) * Fix formatting typo in CPM (#2832) * Add Gitea to NuGet hosting solutions (#2828) * Add Gitea to NuGet hosting solutions * Use Gitea project URL * Update NU1100.md (#2829) NU1100 may also be caused by the lack of a NuGet configura * Updates to ms.date values based on file history (#2831) * Updates to ms.date values based on file history * edit * fixed year * Alphabetize nuget list (#2837) * Improve NU1100 (#2838) * Add CODEOWNERS to docs PRs (#2836) * Release notes for 6.3 (#2834) * release notes for 6.3 Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: andrei <andreiepure@users.noreply.github.com> Co-authored-by: riQQ <riQQ@users.noreply.github.com> Co-authored-by: Drew Noakes <git@drewnoakes.com> Co-authored-by: John Olheiser <john+github@jolheiser.com> Co-authored-by: Nestor Waldyd <nwaldyd@yahoo.co.uk> Co-authored-by: Mike Jones <mikejo@microsoft.com> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com> * November / NuGet 6.4 Merge (#2934) * In all content, remove (#2920) ms.prod = nuget Replace with ms.service = nuget Co-authored-by: Docs Allowlist Management <docs-allowlist-mgmt@microsoft.com> * Update VS extensibility docs (#2929) * Document various log codes (#2933) Documenting: NU1008, NU1009, NU1010, NU1011, NU1109, NU1402, NU1403, NU5042, NU5049 * Release notes for 6.4 (#2926) * Suggest a more generally appropriate import tag (#2932) * Suggest a more generally appropriate import tag Co-authored-by: opbld17 <opbld17@microsoft.com> Co-authored-by: Docs Allowlist Management <docs-allowlist-mgmt@microsoft.com> Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: Jean-Pierre Briedé <jebriede@microsoft.com> Co-authored-by: Andrew Arnott <andrewarnott@gmail.com> * Ms.date update * Updating ms.date --------- Co-authored-by: Christopher R. Gill <christopher.gill@microsoft.com> Co-authored-by: Jon Douglas <jodou@microsoft.com> Co-authored-by: Christopher R. Gill <chrisraygill@gmail.com> Co-authored-by: Joel Verhagen <jver@microsoft.com> Co-authored-by: Nikolche Kolev <nikolce1kolev@gmail.com> Co-authored-by: Jon Douglas <jonathan.douglas@microsoft.com> Co-authored-by: Kartheek Penagamuri <52756182+kartheekp-ms@users.noreply.github.com> Co-authored-by: Simon Cropp <simon.cropp@gmail.com> Co-authored-by: andrei <andreiepure@users.noreply.github.com> Co-authored-by: riQQ <riQQ@users.noreply.github.com> Co-authored-by: Drew Noakes <git@drewnoakes.com> Co-authored-by: John Olheiser <john+github@jolheiser.com> Co-authored-by: Nestor Waldyd <nwaldyd@yahoo.co.uk> Co-authored-by: John Olheiser <john.olheiser@gmail.com> Co-authored-by: Martin Ruiz <martin.ruiz.mares@gmail.com> Co-authored-by: opbld17 <opbld17@microsoft.com> Co-authored-by: Docs Allowlist Management <docs-allowlist-mgmt@microsoft.com> Co-authored-by: Andy Zivkovic <zivkan@users.noreply.github.com> Co-authored-by: Jean-Pierre Briedé <jebriede@microsoft.com> Co-authored-by: Andrew Arnott <andrewarnott@gmail.com> Co-authored-by: Your Name <you@example.com>
Fixes - https://github.com/NuGet/docs.microsoft.com-nuget/issues/2835
Added @NuGet/nuget-client, @NuGet/nuget-pm as CODEOWNERS for the docs repo.
@nkolev92 @zivkan @JonDouglas @aortiz-msft - GitHub is reporting following errors for new file added in this PR. Can we add necessary privileges?
Unknown owner on line 5: make sure the team @NuGet/nuget-client exists and has write access to the repository
Unknown owner on line 5: make sure the team @NuGet/nuget-pm exists and has write access to the repository