Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials Table #1616

Merged
merged 18 commits into from
Oct 4, 2013
Merged

Credentials Table #1616

merged 18 commits into from
Oct 4, 2013

Conversation

analogrelay
Copy link
Contributor

Fixes #1389 👌

This is to pave the way for OAuth . I wanted to get this in and stable before making committing too far on OAuth so I'm going to put this in this sprint and OAuth next sprint (finally!).

✨ Code Review Notes ✨

  • Note the View I create in the Migration. How do we feel about views? I think we could use a few for better data browsing (for example, I'm tired of always having to JOIN on PackageRegistration :)). Happy to remove if people don't like it.

✨ Test Notes ✨

NOTE: Before deploying, make sure there are some existing accounts with API Keys and Passwords to play with. Make sure you know the Password and API Key for each of these accounts.

Before running "galops pc"

  • Verify you can log on
  • Verify you can see the correct API Key
  • Verify you can reset your API Key and see the new one
  • Verify you can change your password
  • Verify you can reset your password by email confirmation
  • Verify you can use your API Key to push packages

After running "galops pc"

Repeat the above.

Invariants

You should always be able to perform ALL user operations on either side of running "galops pc". The code is ✨ Super Leniant ✨

✨ Deployment Notes ✨

  • Run Migration
  • Deploy Code
  • Run "galops pc -!" to verify that there are no problems creating Credential records
  • Run "galops pc" to actually create Credential records for ALL users

}

[HttpDelete]
[ActionName("DeletePackageApi")]
[RequireRemoteHttps(OnlyWhenAuthenticated = false)]
[ApiKeyAuthorizeAttribute]
[ApiKeyAuthorize]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor pet peeve :), figured a quick find-replace was worth it.

@analogrelay
Copy link
Contributor Author

Build failures were due to a deadlock on the build agent. It should be unblocked now.

@analogrelay analogrelay merged commit d048af7 into dev Oct 4, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant