-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credentials Table #1616
Merged
Merged
Credentials Table #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and to clear out old and busted API key)
} | ||
|
||
[HttpDelete] | ||
[ActionName("DeletePackageApi")] | ||
[RequireRemoteHttps(OnlyWhenAuthenticated = false)] | ||
[ApiKeyAuthorizeAttribute] | ||
[ApiKeyAuthorize] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor pet peeve :), figured a quick find-replace was worth it.
Build failures were due to a deadlock on the build agent. It should be unblocked now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389 👌
This is to pave the way for OAuth . I wanted to get this in and stable before making committing too far on OAuth so I'm going to put this in this sprint and OAuth next sprint (finally!).
✨ Code Review Notes ✨
✨ Test Notes ✨
NOTE: Before deploying, make sure there are some existing accounts with API Keys and Passwords to play with. Make sure you know the Password and API Key for each of these accounts.
Before running "galops pc"
After running "galops pc"
Repeat the above.
Invariants
You should always be able to perform ALL user operations on either side of running "galops pc". The code is ✨ Super Leniant ✨
✨ Deployment Notes ✨