[Final Code, but not ready to merge] Credentials Table #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…even if there are validation errors.
…be just a button on the display package page. Not a separate page. Conflicts: src/NuGetGallery/PackagesController.generated.cs
…e browser+scenario dependent.
Now, instead of fadeOut/fadeIn, we animate opacity to and from 0 and when the menu is invisible, we detach it from layout (position:absolute) and move it out of the way of the expanding search box.
…tle accessibility Seems to be the best we can do...
Fixes issues with display on Safari
Fix #1483 by tweaking hide/unhide techinque for menu.
…emapping Fix #1552 by adding a script resource mapping
Conflicts: .nuget/NuGet.targets build.cmd
…reshingInvalidPostRequest Tilovell/1544 server errors when refreshing invalid post request
…sASimpleButton Tilovell/1447 make undo pending edits a simple button
…ifyPackagePage Tilovell/1461 make cancel button work on verify package page
Conflicts: build.cmd src/NuGetGallery.Core/Entities/EntitiesContext.cs src/NuGetGallery.Operations/Tasks/TaskBases.cs
Conflicts: src/NuGetGallery/DataServices/PackageExtensions.cs src/NuGetGallery/DataServices/V2FeedPackage.cs src/NuGetGallery/Infrastructure/Lucene/LuceneSearchService.cs src/NuGetGallery/PackagesController.generated.cs src/NuGetGallery/Web.config
(and to clear out old and busted API key)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1389
Adds a Credentials table to store API Keys and Hashed Passwords. Helps prepare for OAuth support next sprint.
Note: This PR should NOT be merged in as it isn't the final merge. I'll be rebasing this on @TimLovellSmith 's sign-up changes and updating it next sprint. There will be a PR there, but I wanted to get this PR out because it's basically all the functional changes, it's just missing the changes necessary to reconcile it with Tim's changes.