Remove netstandard1.x dependencies in source-build #5885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unnecessary netstandard1.x dependencies - Make NuGet.Build.Tasks.Pack target net and netfx - Upgrade Microsoft.CSharp version to latest 4.7.0 (to avoid bringing in netstandard1.x) Unrelated: - Mark build.sh as executable (chmod +x)
dotnet-policy-service
bot
added
the
Community
akoeplinger
reviewed
Jun 28, 2024
| @@ -41,7 +41,7 @@ | |||
| <None Include="$(BuildCommonDirectory)NOTICES.txt" Pack="true" PackagePath="\" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition=" '$(TargetFramework)' != '$(NETFXTargetFramework)' "> | |||
| <ItemGroup Condition=" '$(TargetFramework)' == '$(NETCoreTargetFramework)' "> | |||
dotnet-policy-service
bot
added
the
Status:No recent activity
dotnet-policy-service
bot
removed
the
Status:No recent activity
ViktorHofer
commented
Jul 15, 2024
| @@ -41,7 +41,7 @@ | |||
| <None Include="$(BuildCommonDirectory)NOTICES.txt" Pack="true" PackagePath="\" /> | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup Condition=" '$(TargetFramework)' != '$(NETFXTargetFramework)' "> | |||
| <ItemGroup Condition=" '$(TargetFramework)' == '$(NETCoreTargetFramework)' "> | |||
| <PackageReference Include="Microsoft.Build.Framework" ExcludeAssets="runtime" GeneratePathProperty="true" /> | |||
There was a problem hiding this comment.
@rainersigwald is it recommended to reference the MSBuild packages on all frameworks or just on the ones where references aren't available? Asking as in L35-L36, msbuild references are used from the .NET Framework installation when targeting netfx.
There was a problem hiding this comment.
The .NET Framework references are the "most compatible" option, but . . . do we really support modern Pack-in-MSBuild in Visual Studio 2010? That doesn't seem required.
I would lean toward "reference the packages at the explicit lowest-supported-version for the netfx output".
dotnet-policy-service
bot
added
the
Status:No recent activity
|
I will get back to this when I return from my leave but I would be happy if someone else wants to pick this up. cc @MichaelSimons |
dotnet-policy-service
bot
removed
the
Status:No recent activity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: dotnet/source-build#4482
Regression? Last working version:
Description
(NuGet.Build.Tasks.Pack and build/docs.proj)
Unrelated:
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation