Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NoWarn for NETSDK1138 #4854

Merged
merged 2 commits into from
Oct 13, 2022
Merged

NoWarn for NETSDK1138 #4854

merged 2 commits into from
Oct 13, 2022

Conversation

donnie-msft
Copy link
Contributor

Bug

Fixes: NuGet/Home#12158

Regression? Last working version:

Description

As a library targeting an EOL version of the framework, this error is attempting to suggest we should upgrade. We ultimately don't have a dependency on the .NET 5 runtime, as the .NET SDK determines that.

This PR disables the compiler warning. See suggested changes to this behavior in dotnet/sdk#24747.

Warning/Error that goes away with this PR:

C:\Program Files\dotnet\sdk\7.0.100-rc.2.22477.23\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targ
ets(28,5): error NETSDK1138: The target framework 'netcoreapp5.0' is out of support and will not receive security updat
es in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy.

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
    • OR
    • Test exception
    • OR
    • N/A

  • Documentation

    • Documentation PR or issue filled
    • OR
    • N/A

@donnie-msft donnie-msft requested a review from a team as a code owner October 13, 2022 18:18
nkolev92
nkolev92 approved these changes Oct 13, 2022
View reviewed changes
test/TestExtensions/GenerateLicenseList/GenerateLicenseList.csproj
@@ -7,7 +7,7 @@
<OutputType>Exe</OutputType>
<TargetFramework>net5.0</TargetFramework>
<AssemblyName>GenerateLicenseList</AssemblyName>
<NoWarn>NU1505</NoWarn> <!-- Remove NoWarn when https://github.com/dotnet/sdk/issues/24747 is fixed -->
<NoWarn>$(NoWarn);NU1505</NoWarn> <!-- Remove NoWarn when https://github.com/dotnet/sdk/issues/24747 is fixed -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be removed altogether as the linked issue is likely fixed, but I understand if you don't want to risk it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's blocking everyone, let's merge this without messing with other warnings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense.

Approval stands, feel free to merge.

@donnie-msft donnie-msft merged commit 6a986d7 into dev Oct 13, 2022
@donnie-msft donnie-msft deleted the dev-donnie-msft-nowarn1138 branch October 13, 2022 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolev92 nkolev92 nkolev92 approved these changes

@erdembayar erdembayar erdembayar approved these changes

@zivkan zivkan zivkan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error NETSDK1138: The target framework 'netcoreapp5.0' is out of support when updated VS
4 participants
@donnie-msft @nkolev92 @zivkan @erdembayar