Update Microsoft.Build.Locator version #4247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkl
approved these changes
Sep 4, 2021
|
@NuGet/nuget-client |
zivkan
approved these changes
Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#11158
Related to NuGet/Home#11169
Regression? Last working version: n/a
Description
Open NuGet.sln in VS, set NuGet.CommandLine.XPlat as startup project, set Debug command line parameters as package list SomeProject.csproj --deprecated (any report type should fail) and debug. You will see:
error: Could not load file or assembly 'System.Runtime.CompilerServices.Unsafe, Version=4.0.4.1, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
I investigated this issue with @jeffkl and it happens to be
Microsoft.Build.Locatorissue. It's same as microsoft/MSBuildLocator#95After this change I manually tested above scenario works, I'll add tests with when addressing NuGet/Home#11169
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation