Don't use the license element in a snupkg #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
changed the title
nkolev92
changed the title
nkolev92
requested review from
PatoBeltran,
dominoFire,
jainaashish,
zivkan and
heng-liu
PatoBeltran
approved these changes
Jan 10, 2019
src/NuGet.Core/NuGet.Packaging/PackageCreation/Authoring/PackageBuilder.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7591
Regression: No, 2 features from the same release don't play well together
If Regression then when did it last work:
If Regression then how are we preventing it in future:
Fix
Details:
The license information should not be included in snupkgs.
Related https://github.com/NuGet/docs.microsoft.com-nuget/issues/1254
Note: This is a change that targets 4.9.x
//cc @karann-msft @anangaur @rrelyea FYI
Testing/Validation
Tests Added: Yes
Reason for not adding tests:
Validation done: Tests, automation