Do not fail verification if owners don't match #2550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatoBeltran
requested review from
dominoFire,
nkolev92,
zivkan,
dtivel,
jainaashish and
heng-liu
jainaashish
approved these changes
Dec 4, 2018
src/NuGet.Core/NuGet.Packaging/Signing/Verification/AllowListVerificationProvider.cs
Outdated
Show resolved
Hide resolved
dtivel
approved these changes
Dec 4, 2018
nkolev92
approved these changes
Dec 5, 2018
PatoBeltran
changed the base branch from
release-4.9.2-rtm
to
release-4.9.3-rtm
PatoBeltran
added a commit
that referenced
this pull request
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#7572
Fix
Details: When
AllowListVerificationProvidermatched a signing certificate with a trusted repository entry that has owners, it failed the whole allow list verification if those owners did not match any of the ones that signed the package. This becomes an issue if there's a trusted signer entry later in the list that does match this package (e.g. a trusted author for the author signature).cc. @rido-min