disable automatically pushing symbols package to symbol server #1815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit21agrawal
requested review from
PatoBeltran,
nkolev92,
emgarten,
zhili1208,
mishra14 and
jainaashish
zhili1208
approved these changes
Nov 21, 2017
|
🥇 |
rohit21agrawal
pushed a commit
that referenced
this pull request
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#6113
Regression: No
If Regression then when did it last work: N/A
If Regression then how are we preventing it in future: N/A
Fix
Details: This fix prevents symbols from automatically being uploaded to the symbol server if the package source is nuget.org and the symbols package is right next to the main nupkg.
Testing/Validation
Tests Added: No
Reason for not adding tests: Since this was a very specific scenario for nuget.org, we can't validate it against actual nuget.org.
Validation done: Manual testing.