Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore: DependencyGraphSpec.Load(...) does not need JObject #9040

Closed
dtivel opened this issue Jan 9, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3239
Closed

Restore: DependencyGraphSpec.Load(...) does not need JObject #9040

dtivel opened this issue Jan 9, 2020 · 0 comments · Fixed by NuGet/NuGet.Client#3239
Assignees
@dtivel
Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Tenet:Performance Performance issues Type:Bug
Milestone
Sprint 166 - 2020...

Comments

@dtivel
Copy link
Contributor

dtivel commented Jan 9, 2020

DependencyGraphSpec.Json is unused except by tests. Holding both the Newtonsoft.Json.Linq.JObject and the NuGet representations of a dependency graph spec in memory is completely unnecessary.

Recommendations:

  1. Remove the DependencyGraphSpec.Json property.
  2. Update DependencyGraphSpec.Load(string) to deserialize a DependencyGraphSpec object incrementally using a Newtonsoft.Json.JsonTextReader and avoid deserializing completely into a JObject first.
@dtivel dtivel self-assigned this Jan 24, 2020
@rrelyea rrelyea added this to the Sprint 165 - 2020.01.20 milestone Feb 6, 2020
@dtivel dtivel mentioned this issue Feb 11, 2020
Closed
@nkolev92 nkolev92 added the Category:Quality Week Issues that should be considered for quality week label Feb 13, 2020
@dtivel dtivel mentioned this issue Feb 16, 2020
Merged
dtivel added a commit to NuGet/NuGet.Client that referenced this issue Feb 26, 2020
@dtivel
Restore: improve DependencyGraphSpec memory usage (#3239)
dfe17b4 
Fix NuGet/Home#9040
@zkat zkat reopened this Mar 18, 2020
@zkat zkat closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dtivel dtivel

Labels
Category:Quality Week Issues that should be considered for quality week Functionality:Restore Tenet:Performance Performance issues Type:Bug
Projects
None yet
Milestone
Sprint 166 - 2020.02.10
Development

Successfully merging a pull request may close this issue.

Restore: improve DependencyGraphSpec memory usage NuGet/NuGet.Client
6 participants
@zkat @nkolev92 @rrelyea @dtivel @kartheekp-ms @aortiz-msft