Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone md5 model support #765

Merged
merged 2 commits into from
Feb 8, 2025
Merged

Standalone md5 model support #765

merged 2 commits into from
Feb 8, 2025

Conversation

NHogweed
Copy link
Contributor

Now, if there is a md5 model, but no mdl with the same name, the engine will use the former instead of returning an error. This ignores r_loadmd5models and r_md5models.

@vsonnier vsonnier self-requested a review January 18, 2025 17:22
@vsonnier vsonnier self-assigned this Jan 18, 2025
@vsonnier vsonnier removed their request for review January 18, 2025 17:22
@vsonnier
Copy link
Collaborator

I @NHogweed, thanks for this. Now, the code around the selection of which model to load it getting too messy for my taste, especially with the goto addition :) I'm going to move the model selection to a separate function to be more explicit and readable.

No need to touble yourself further though, I'll take care of the rest from this.

@NHogweed
Copy link
Contributor Author

OK. I'm keeping my code until that though, just for any case.

@vsonnier vsonnier merged commit 35434bd into Novum:master Feb 8, 2025
11 checks passed
@vsonnier
Copy link
Collaborator

vsonnier commented Feb 8, 2025

Hi @NHogweed finally I merged your modification as-is. I wanted to be pedantic at first and redo this, but hey, I'm lacking time and as we say home : "le mieux est l'ennemi du bien" or if you prefer here Practicality beats Purity :)

Seriously though, your change was not that big, and is still easy enough to follow.

Thanks for your contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants