Fix the bug of traversing collections #658
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Euruson
force-pushed
the
fix-collection-traverse
branch
from
71f9db0 to
978cdf3
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| @@ -34,7 +34,7 @@ export function getCollectionGroups( | |||
| } | |||
|
|
|||
| // TODO: review dates format based on value.type ('week'|'month'|'year') | |||
| queryValue = format(new Date(queryLabel), 'MMM d, YYY hh:mm aa') | |||
| queryValue = format(new Date(queryLabel), 'MMM d, yyy hh:mm aa') | |||
There was a problem hiding this comment.
The date format pattern yyy will display only 3 digits for the year (e.g., "202" instead of "2023"). To correctly display a 4-digit year, the pattern should be yyyy. This same issue appears in multiple places throughout the PR and should be fixed in all occurrences.
Suggested change
| queryValue = format(new Date(queryLabel), 'MMM d, yyy hh:mm aa') | |
| queryValue = format(new Date(queryLabel), 'MMM d, yyyy hh:mm aa') |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
getAllPagesInSpace()function innotion-utilsis valuable for sitemap generation and SSG. However, the current implementation fails to retrieve subpages within collections. This is because it searches for blockIds inside CollectionQueryResult, where the results are typically not present.Upon investigation, I found that the relevant subpage data primarily resides in
CollectionQueryResult.collection_group_results, not in the main CollectionQueryResult itself.Notion Test Page ID
You can verify this behavior by logging the results during the build process.