Minor inspection fixes.

Nosto · Nov 8, 2021 · a44891b · a44891b
1 parent 06bdaed
commit a44891b
Show file tree

Hide file tree

Showing 12 changed files with 33 additions and 22 deletions.
diff --git a/beanie-core/src/main/java/com/nosto/beanie/CollectionHandlingTest.java b/beanie-core/src/main/java/com/nosto/beanie/CollectionHandlingTest.java
@@ -29,6 +29,7 @@ public interface CollectionHandlingTest<T> extends BeanieTest<T> {
      * Generate multiple random objects of the given class
      * and assert serializing and deserializing back returns
      * the original object.
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     default void testSerdeCollection(Class<? extends T> concreteClass) {
         EasyRandomParameters randomParameters = getEasyRandomParameters();
@@ -54,6 +55,7 @@ default void testSerdeCollection(Class<? extends T> concreteClass) {
      * Generate multiple random objects of the given class
      * and assert serializing and deserializing back returns
      * the original object.
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     default void testSerdeCollectionAsWell(Class<? extends T> concreteClass) {
         EasyRandomParameters randomParameters = getEasyRandomParameters();

diff --git a/beanie-core/src/main/java/com/nosto/beanie/DefaultBeanieProvider.java b/beanie-core/src/main/java/com/nosto/beanie/DefaultBeanieProvider.java
@@ -13,10 +13,6 @@
 
 import com.fasterxml.jackson.databind.ObjectMapper;
 
-
-/**
- * @author mridang
- */
 public final class DefaultBeanieProvider implements BeanieProvider {
 
     private final ObjectMapper objectMapper;

diff --git a/beanie-core/src/main/java/com/nosto/beanie/FinalPropertiesTest.java b/beanie-core/src/main/java/com/nosto/beanie/FinalPropertiesTest.java
@@ -23,6 +23,7 @@ public interface FinalPropertiesTest<T> extends BeanieTest<T> {
 
     /**
      * All fields should be final
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     default void testFinalProperties(Class<? extends T> concreteClass) {
         List<AnnotatedField> fields = getDescription(concreteClass).findProperties()

diff --git a/beanie-core/src/main/java/com/nosto/beanie/NamingStrategyTest.java b/beanie-core/src/main/java/com/nosto/beanie/NamingStrategyTest.java
@@ -26,6 +26,7 @@ public interface NamingStrategyTest<T> extends BeanieTest<T> {
     /**
      * Test that all properties of a bean are named with a consistent naming strategy and all property names
      * comply with the bean's naming strategy.
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     default void testNamingStrategy(Class<? extends T> concreteClass) {
         BeanDescription beanDescription = getDescription(concreteClass);

diff --git a/beanie-core/src/main/java/com/nosto/beanie/NoSettersTest.java b/beanie-core/src/main/java/com/nosto/beanie/NoSettersTest.java
@@ -19,6 +19,7 @@ public interface NoSettersTest<T> extends BeanieTest<T> {
 
     /**
      * Check that there is no setters
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     default void testNoSetters(Class<? extends T> concreteClass) {
         List<BeanPropertyDefinition> properties = getDescription(concreteClass).findProperties()

diff --git a/beanie-core/src/main/java/com/nosto/beanie/SerdeKosherTest.java b/beanie-core/src/main/java/com/nosto/beanie/SerdeKosherTest.java
@@ -24,6 +24,7 @@ public interface SerdeKosherTest<T> extends BeanieTest<T> {
      * Generate multiple random objects of the given class
      * and assert serializing and deserializing back returns
      * the original object.
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     default void testSerde(Class<? extends T> concreteClass) {
         EasyRandomParameters randomParameters = getEasyRandomParameters();

diff --git a/junit-jupiter/src/main/java/com/nosto/beanie/AbstractJacksonBeanTest.java b/junit-jupiter/src/main/java/com/nosto/beanie/AbstractJacksonBeanTest.java
@@ -47,7 +47,7 @@ public abstract class AbstractJacksonBeanTest<T> implements JupiterBeanieTest<T>
     }
 
     public static Stream<Class<? extends JacksonBean>> getClasses() {
-        Reflections reflections = new Reflections((new ConfigurationBuilder())
+        Reflections reflections = new Reflections(new ConfigurationBuilder()
                 .setUrls(ClasspathHelper.forPackage("com.nosto")));
         return reflections.getSubTypesOf(JacksonBean.class).stream();
     }
@@ -84,13 +84,14 @@ public static Stream<Class<? extends JacksonBean>> noSetters() {
 
     @SuppressWarnings("unused")
     public static Stream<Class<? extends JacksonBean>> finalProperties() {
-        Reflections reflections = new Reflections((new ConfigurationBuilder())
+        Reflections reflections = new Reflections(new ConfigurationBuilder()
                 .setUrls(ClasspathHelper.forPackage("com.nosto")));
         return reflections.getSubTypesOf(JacksonBean.class).stream();
     }
 
     /**
-     * @see ConstructorParametersTest#testConstructorParameters(Class)
+     * For more information @see ConstructorParametersTest#testConstructorParameters(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource
@@ -99,7 +100,8 @@ public void constructorParameters(Class<T> concreteClass) {
     }
 
     /**
-     * @see SerdeKosherTest#testSerde(Class)
+     * For more information @see SerdeKosherTest#testSerde(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource
@@ -108,7 +110,8 @@ public void serde(Class<T> concreteClass) {
     }
 
     /**
-     * @see NamingStrategyTest#testNamingStrategy(Class)
+     * For more information @see NamingStrategyTest#testNamingStrategy(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource
@@ -117,7 +120,8 @@ public void namingStrategy(Class<T> concreteClass) {
     }
 
     /**
-     * @see CollectionHandlingTest#testSerdeCollection(Class)
+     * For more information @see CollectionHandlingTest#testSerdeCollection(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource
@@ -126,7 +130,8 @@ public void serdeCollection(Class<T> concreteClass) {
     }
 
     /**
-     * @see CollectionHandlingTest#testSerdeCollectionAsWell(Class)
+     * For more information @see CollectionHandlingTest#testSerdeCollectionAsWell(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource
@@ -135,7 +140,8 @@ public void serdeCollectionAsWell(Class<T> concreteClass) {
     }
 
     /**
-     * @see NoSettersTest#testNoSetters(Class)
+     * For more information @see NoSettersTest#testNoSetters(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource
@@ -144,7 +150,8 @@ public void noSetters(Class<T> concreteClass) {
     }
 
     /**
-     * @see FinalPropertiesTest#testFinalProperties(Class)
+     * For more information @see FinalPropertiesTest#testFinalProperties(Class)
+     * @param concreteClass the bean class to be tests as provided by Junit
      */
     @ParameterizedTest
     @MethodSource

diff --git a/junit-jupiter/src/main/java/com/nosto/beanie/JupiterBeanieTest.java b/junit-jupiter/src/main/java/com/nosto/beanie/JupiterBeanieTest.java
@@ -17,6 +17,7 @@
 @SuppressWarnings("unused")
 public interface JupiterBeanieTest<T> extends BeanieTest<T> {
 
+    @Override
     default RandomizerRegistry getRandomizerRegistry() {
         return new CustomRandomizerRegistry();
     }

diff --git a/junit-jupiter/src/test/java/com/nosto/beanie/AbstractTestBean.java b/junit-jupiter/src/test/java/com/nosto/beanie/AbstractTestBean.java
@@ -1,6 +1,6 @@
 /*
  *  Copyright (c) 2021 Nosto Solutions Ltd All Rights Reserved.
- *
+ *  
  *  This software is the confidential and proprietary information of
  *  Nosto Solutions Ltd ("Confidential Information"). You shall not
  *  disclose such Confidential Information and shall use it only in

diff --git a/junit-vintage/src/main/java/com/nosto/beanie/AbstractJacksonBeanTest.java b/junit-vintage/src/main/java/com/nosto/beanie/AbstractJacksonBeanTest.java
@@ -50,55 +50,55 @@ public AbstractJacksonBeanTest(Class<? extends T> clazz) {
     }
 
     /**
-     * @see ConstructorParametersTest#testConstructorParameters(Class)
+     * For more information @see ConstructorParametersTest#testConstructorParameters(Class)
      */
     @Test
     public void constructorParameters() {
         testConstructorParameters(concreteClass);
     }
 
     /**
-     * @see SerdeKosherTest#testSerde(Class)
+     * For more information @see SerdeKosherTest#testSerde(Class)
      */
     @Test
     public void serde() {
         testSerde(concreteClass);
     }
 
     /**
-     * @see NamingStrategyTest#testNamingStrategy(Class)
+     * For more information @see NamingStrategyTest#testNamingStrategy(Class)
      */
     @Test
     public void namingStrategy() {
         testNamingStrategy(concreteClass);
     }
 
     /**
-     * @see CollectionHandlingTest#testSerdeCollection(Class)
+     * For more information @see CollectionHandlingTest#testSerdeCollection(Class)
      */
     @Test
     public void serdeCollection() {
         testSerdeCollection(concreteClass);
     }
 
     /**
-     * @see CollectionHandlingTest#testSerdeCollectionAsWell(Class)
+     * For more information @see CollectionHandlingTest#testSerdeCollectionAsWell(Class)
      */
     @Test
     public void serdeCollectionAsWell() {
         testSerdeCollectionAsWell(concreteClass);
     }
 
     /**
-     * @see NoSettersTest#testNoSetters(Class)
+     * For more information @see NoSettersTest#testNoSetters(Class)
      */
     @Test
     public void noSetters() {
         testNoSetters(concreteClass);
     }
 
     /**
-     * @see FinalPropertiesTest#testFinalProperties(Class) 
+     * For more information @see FinalPropertiesTest#testFinalProperties(Class) 
      */
     @Test
     public void finalProperties() {

diff --git a/junit-vintage/src/main/java/com/nosto/beanie/VintageBeanieTest.java b/junit-vintage/src/main/java/com/nosto/beanie/VintageBeanieTest.java
@@ -17,6 +17,7 @@
 @SuppressWarnings("unused")
 public interface VintageBeanieTest<T> extends BeanieTest<T> {
 
+    @Override
     default RandomizerRegistry getRandomizerRegistry() {
         return new CustomRandomizerRegistry();
     }

diff --git a/junit-vintage/src/test/java/com/nosto/beanie/AbstractTestBean.java b/junit-vintage/src/test/java/com/nosto/beanie/AbstractTestBean.java
@@ -1,6 +1,6 @@
 /*
  *  Copyright (c) 2021 Nosto Solutions Ltd All Rights Reserved.
- *
+ *  
  *  This software is the confidential and proprietary information of
  *  Nosto Solutions Ltd ("Confidential Information"). You shall not
  *  disclose such Confidential Information and shall use it only in