Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement 137 #149

Merged
merged 7 commits into from
Nov 18, 2024
Merged

Enhancement 137 #149

merged 7 commits into from
Nov 18, 2024

Conversation

jorgezerpa
Copy link
Contributor

Detailed Information

Some enhancements to the current code base:

  • Create a specific Interface for each contract (NFT and LandRegister) instead of a single interface file.
  • Extract the events of the contract into the interface files so it's easier to access them on tests.
  • There are some error messages that are not in custom error files, instead are hardcoded into the assert message.
  • Some errors of the NFT contract are inside a local errors module instead of the custom_error file, which may be a bit confusing.

Note: This changes has the current changes of the marketplace -> #148


Closes #137


Type of Change

  • 🐛 Bug fix or ⚙️ enhancement
  • ✨ New feature or Chore (change with no new features or fixes)
  • 📚 Documentation update

Checklist (select as many as applicable)

  • The code follows the style guidelines of this project.
  • All new and existing tests pass.
  • This pull request is ready to be merged and reviewed.

@fishonamos fishonamos merged commit ccda93b into NoshonNetworks:main Nov 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance land registry smart contracts
2 participants