Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7

Merged
merged 13 commits into from
Nov 1, 2022
Merged

Fixes #7

merged 13 commits into from
Nov 1, 2022

Conversation

Fermain
Copy link
Collaborator

@Fermain Fermain commented Nov 1, 2022

No description provided.

@Fermain Fermain added the enhancement New feature or request label Nov 1, 2022
Copy link
Member

@jaaneh jaaneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were some unused imports which I removed in 73a6aaa.

Still some unused functions, function params, and variables which could be removed, but wasn't sure if you've left on purpose for future? For example, js/templates/image/index.js is unused.

@Fermain
Copy link
Collaborator Author

Fermain commented Nov 1, 2022

There were some unused imports which I removed in 73a6aaa.

Still some unused functions, function params, and variables which could be removed, but wasn't sure if you've left on purpose for future? For example, js/templates/image/index.js is unused.

This was a failed experiement, can also be removed

Copy link
Member

@jaaneh jaaneh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

If anything, (and with me being me), I would probably use optional chaining instead of nested && where you currently are. That's ultimately up to you, though 👍

if (profile && profile.followers && profile.followers.length) {}
// replace with
if (profile?.followers?.length) {}

@Fermain Fermain removed the request for review from sulenchy November 1, 2022 13:37
@Fermain Fermain merged commit f5e3f47 into master Nov 1, 2022
@jaaneh jaaneh deleted the fixes branch November 1, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants