-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were some unused imports which I removed in 73a6aaa.
Still some unused functions, function params, and variables which could be removed, but wasn't sure if you've left on purpose for future? For example, js/templates/image/index.js
is unused.
This was a failed experiement, can also be removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
If anything, (and with me being me), I would probably use optional chaining instead of nested && where you currently are. That's ultimately up to you, though 👍
if (profile && profile.followers && profile.followers.length) {}
// replace with
if (profile?.followers?.length) {}
No description provided.