-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workflow #389
Open
EF-Pami
wants to merge
34
commits into
NoroffFEU:master
Choose a base branch
from
EF-Pami:workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Workflow #389
Changes from 15 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
d340db1
installing prettier
EF-Pami 58f672a
adding formatting script
EF-Pami 1cc6104
1.0.1
EF-Pami 2fd2e70
changing type to module
EF-Pami 2a6330d
installing eslint
EF-Pami d1e870b
installing eslint
EF-Pami bcc18b8
configuring eslint
EF-Pami 10fc626
adding lint to script
EF-Pami 1ddda9a
adding lint-fix to script
EF-Pami d109aee
adding gitHub link to package.json
EF-Pami bfa910a
just testing format in prettier
EF-Pami b530979
installing husky
EF-Pami bc80767
installing jest
EF-Pami 4591bf8
adding test and test-unit to script
EF-Pami f5aeb40
adding overrides to eslintrc
EF-Pami d4d3f44
adding app.test.js file
EF-Pami 58d6f0a
adding eslintcache
EF-Pami d9df945
installing and configuring babel
EF-Pami e7850e5
trying the test function on apple.js
EF-Pami b68ebbe
update on eslintcache
EF-Pami 7c496f2
installing and configuring cypress
EF-Pami 2cc2539
adding overrides for cypress into eslintrc.json
EF-Pami b310281
cypress configuration js file
EF-Pami 9f33e9d
adding to gitignore
EF-Pami cd6e2af
update on cypress support files
EF-Pami 45ca825
update on eslintcache
EF-Pami 3893fcd
added localstorage.mock.js
EF-Pami 21cb4b0
update husky
EF-Pami a87fe0a
added ReadME File
EF-Pami ee4d74c
Update apple.js
EF-Pami 35b2a5c
Update .eslintcache
EF-Pami a288c8e
added logout.cy.js
EF-Pami 40e8951
update .eslintcache
EF-Pami 5ec440c
update package.json for automated testing
EF-Pami File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| { | ||
| "env": { | ||
| "browser": true, | ||
| "es2021": true | ||
| }, | ||
| "extends": "eslint:recommended", | ||
| "overrides": [ | ||
| { | ||
| "files": ["**/*.test.js"], | ||
| "env": { "jest": true }, | ||
| "plugins": ["jest"], | ||
| "extends": ["plugin:jest/recommended"], | ||
| "rules": { "jest/prefer-expect-assertions": "off" } | ||
| } | ||
| ], | ||
| "parserOptions": { | ||
| "ecmaVersion": "latest", | ||
| "sourceType": "module" | ||
| }, | ||
| "rules": { | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| _ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/sh | ||
| . "$(dirname "$0")/_/husky.sh" | ||
|
|
||
| npx lint-staged |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
|
|
||
| added 54 packages, and audited 368 packages in 4s | ||
|
|
||
| 60 packages are looking for funding | ||
| run `npm fund` for details | ||
|
|
||
| 3 high severity vulnerabilities | ||
|
|
||
| To address all issues (including breaking changes), run: | ||
| npm audit fix --force | ||
|
|
||
| Run `npm audit` for details. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made in this hunk are related to the package management and audit. It seems like there are 3 high severity vulnerabilities found during the audit. While
npm audit fix --forcecan be used to automatically install any updates that break the current code, it's not always the best solution as it might introduce breaking changes into your application.Instead of using
npm audit fix --force, I would recommend manually reviewing and addressing each vulnerability. This way, you can ensure that the fixes don't unintentionally break other parts of your application. You can usenpm auditfor more details about each vulnerability.This change will encourage developers to take a more careful approach when dealing with security vulnerabilities.