Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup spacing in code #453

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Malin-Malin
Copy link

I just received confirmation from the teachers that we are not supposed to update the API, so there was nothing for me to implement in this task. The student display already matches Figma.

What I did:
Reviewed and cleaned up the code.

@Malin-Malin Malin-Malin linked an issue Mar 9, 2025 that may be closed by this pull request
@Malin-Malin Malin-Malin requested a review from GustavBoe March 9, 2025 20:16
Copy link

@GustavBoe GustavBoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Malin! A few, small things to be done before I can approve this PR! I´ve reviewed the mobile version as a width of 390px.

For Mobile

  • Add the correct header.
  • Check the placement and size of the arrows (maybe different font).
  • Make sure that the H1 matches with the design (2 rows instead of 3)
  • Decrease the spacing between h1,p and search bar.
  • Lower the opacity on the placeholder text.
  • Make sure that the elements included in the table are the correct ones.
  • Make the arrows of the pagination match the ones in Figma.
  • Increase border-width of the highlighted box.
  • Change the color/opacity of the pagination boxes to match Figma.
  • Decrease the size of the button.
  • Add the footer image.

For desktop

  • Add the header.
  • Decrease the opacity of the placeholder.
  • Increase the time of the hover-animation.
  • Increase the spacing between search bar and table.
  • Check the spacing between table headers.
  • Ensure correct color of grey fields in the table (rgb 249X3)
  • Ensure that the pagination matches Figma (arrows, color, etc.)
  • Check the spacing between pagination and button.
  • Add the footer image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Story 1: 1.2: Display Top Students List
2 participants