Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added requested changes in add-results html #293

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

RVHUSA
Copy link
Contributor

@RVHUSA RVHUSA commented Jan 22, 2025

What does this PR do?

Updated requested changes.

Description of Task to be completed?

I have updated the changes in the HTML as Tomatsuppe commented below. I think I made a mistake with this when I committed, as I had to save it again to proceed. Because of that, the changes are not showing up for you. I apologize for this...

How should this be manually tested?

Go over en check with the latest comments.

Any background context you want to provide?

No.

added requested changes in add-results html
@RVHUSA RVHUSA self-assigned this Jan 22, 2025
Copy link

@Tomatsuppe11211 Tomatsuppe11211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 quick fixes i saw i missed earlier:

line 42: Change from results to result
image

line 22: Change from h2-tag to a p-tag instead.

When thats done I'll approve this code.

Copy link

@Tomatsuppe11211 Tomatsuppe11211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@Tomatsuppe11211 Tomatsuppe11211 linked an issue Jan 22, 2025 that may be closed by this pull request
Copy link
Contributor

@myrset myrset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 19: To match design the results need to start with uppercase
Line 22: excel needs to start with uppercase to match design

myrset
myrset previously approved these changes Jan 25, 2025
Copy link
Contributor

@myrset myrset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

RVHUSA and others added 2 commits January 30, 2025 20:13
Added styling to add-results and updated tailwindcss to 4.0.1
@RVHUSA RVHUSA linked an issue Feb 3, 2025 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add results (HTML) Add results (CSS)
3 participants