-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Teacher review #302
Open
Padletut
wants to merge
46
commits into
NoroffFEU:main
Choose a base branch
from
Padletut:css-frameworks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Teacher review #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added styles for the footer component - Set the height of the footer to 56px - Added padding-top of 60px to the footer chore: Update cards styles - Added styles for the cards component - Set the box-shadow and min-height properties for the .card-custom class - Set the font-size, margin, and flex-wrap properties for the .card-custom h1 and .form-check-container classes - Set the min-width property for the .card-custom class at a min-width of 576px - Set the display property to none for the .nav-tabs class chore: Update index.scss - Imported variables, bootstrap, and various components in index.scss - Added scroll-behavior: smooth to all elements - Set the font-family to 'Roboto', sans-serif for the body - Set the --bs-body-bg variable to #F9FAFB - Set the height of the body to 100vh - Added padding to the main element - Set the display property to flex for the .card class chore: Add variables - Added variables for body background color, theme colors, button colors, and button shadows feat: Add input validation function - Added a validateInputs function in validateinputs.mjs - Applied custom Bootstrap validation styles to forms with the .needs-validation class feat: Add header styles - Added styles for the header component - Set the height of the header to 90px - Added padding-bottom of 90px to the header - Set the letter-spacing property for the .navbar-nav class - Set custom styles for the .navbar-brand-custom class after the sm breakpoint - Added styles for the input.custom-search class feat: Add sign in and sign up functionality - Imported the validateInputs function from validateinputs.mjs in index.js - Added event listeners for switching between login and register account tabs - Added event listeners for sign in and sign up buttons feat: Add custom button styles - Added styles for custom buttons - Created a mixin for custom buttons with customizable background, border, color, hover background, hover border, hover color, active background, active border, active color, disabled background, disabled border, and disabled color - Applied the custom-button mixin to the .btn-auth-form-custom class chore: Update template.html - Added the necessary HTML structure for the header, main, and footer sections - Imported Bootstrap CSS and custom CSS - Imported Bootstrap JS and validateinputs.js - Set the title of the page to "ConnectSphere - Authorization"
…ptions to the feed
…dding to nav items, moved create new post button on profile page,
…eworks-ca into css-frameworks
…icons import path in index.scss
…yles for consistency
- Changed the image upload field in the create new post modal to allow users to upload an image file instead of entering a URL. - Updated the HTML and SCSS files to reflect this change.
- Updated the password input field in the form to require a minimum of 8 characters. - Added a validation message to prompt users to enter a password with at least 8 characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened this PR because i merged the previous one as Assigment process step 10. Complete the approved Pull Request, or implement the required changes, I understood it as to merge the PR.