-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAN22P #1105 delete listing as client #1114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Feedback
Hi Michael,
Great job on fixing the issue. I have verified the issue, and verified your fix. It works well!
I just have a few things I would like you to do before we merge the PR.
- Add button classes to the close button so it fits better with the design. For example:
<button
id="hide-delete-modal-btn"
class="btn btn-theme-dark rounded-0"
data-bs-dismiss="modal"
data-bs-target="#deleteListingModal">
Close
</button>
- The
cancel-delete-listing-btn
also deletes the listing. Maybe we should fix that while we are in this area. It could just close the modal or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Looks really good! I will merge the changes to JAN22P and delete this branch.
- Erlend
Title
#1105- Deleting a listing as a client
Describe your changes:
Checklist before requesting a review
Feedback