Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap error messages #486

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Wrap error messages #486

merged 1 commit into from
Dec 11, 2023

Conversation

LionelJouin
Copy link
Member

Description

This aims to fix most of the issue the wrapcheck linter reports.

No logic should have been changed, only error messages.

pkg/kernel/vip.go has been removed since it is not used.

Issue link

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

@LionelJouin LionelJouin added kind/enhancement New feature or request size/L labels Dec 8, 2023
@LionelJouin LionelJouin requested a review from zolug December 8, 2023 15:01
zolug
zolug reviewed Dec 10, 2023
View reviewed changes
zolug
zolug reviewed Dec 10, 2023
View reviewed changes
@zolug
Copy link
Collaborator

zolug commented Dec 10, 2023

some typos, otherwise looks good to me

@LionelJouin LionelJouin force-pushed the error-wrap branch 2 times, most recently from 7e4dc96 to f07e128 Compare December 11, 2023 08:25
@LionelJouin
Wrap error messages
c0cde3a 
This aims to fix most of the issue the wrapcheck linter reports.

No logic should have been changed, only error messages.

pkg/kernel/vip.go has been removed since it is not used.
@LionelJouin LionelJouin merged commit 3286c5e into master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zolug zolug zolug left review comments

Assignees
No one assigned
Labels
kind/enhancement New feature or request size/L
Projects
Meridio
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LionelJouin @zolug