New internal gRPC health client instead of grpc-health-probe binary #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Could you update the documentation of the NSP component:
https://github.com/Nordix/Meridio/blob/master/docs/components/nsp.md#health-check
Here is an example with the IPAM: https://github.com/Nordix/Meridio/blob/master/docs/components/ipam.md#health-check
LionelJouin
approved these changes
Nov 10, 2023
Replace grpc-health-probe binary in case of running probes internally invoked from code. The custom health-probe client is contained within the caller process (instead of forking a new PID). Thus, attestation related Spire load could be lowered when using SPIFFE issued credentials to check TLS servers.
- NSP to use custom gRPC health server for readiness probe that does not require the spiffe option. - The TLS server of NSP is probed by an internal gRPC probe. - Operator also updated to deploy NSP with new probe.
The same subservice can be part of multiple probe services. (Probe services are "named" kubernetes probe types referred to as "Startup", "Readiness" or "Liveness" in Meridio.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to the related issue.
Kubernetes native grpc probes are not introduced, because it does not seem to support servers using unix sockets (hence grpc-health-probe binary cannot be removed from the images):
https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.26/#httpgetaction-v1-core
Issue link
#474
Checklist