Set mac address of bridge0 in proxy #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LionelJouin
added
kind/bug
Setting the bridge mac address prevents the address changes when an interface is attached/detached. This caused issue when connecting targets and stateless-lbs to the proxy. The ARP table of other connected pods were not updated instantly. See: #471
LionelJouin
force-pushed
the
issue-471
branch
from
3caa203 to
3e53e75
Compare
zolug
approved these changes
Nov 6, 2023
|
Btw, it doesn't seem matter how well phrased errors Bridge create() returns, because it never gets printed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Setting the bridge mac address prevents the address changes when an interface is attached/detached. This caused issue when connecting targets and stateless-lbs to the proxy. The ARP table of other connected pods were not updated instantly.
Issue link
#471
Checklist