Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lb; during shutdown run all clean-up #469

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Lb; during shutdown run all clean-up #469

merged 2 commits into from
Nov 6, 2023

Conversation

zolug
Copy link
Collaborator

@zolug zolug commented Oct 20, 2023

Description

Due to a buried "Fatal" printout the LB failed to run all the clean-ups (e.g. NSE unregister) during shutdown.

Issue link

NA

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

zolug added 2 commits October 20, 2023 14:55
Remove clientinfo chain to avoid periodic NSM originated printouts,
because env variables NODE_NAME, POD_NAME, CLUSTER_NAME are not set.
Due to a burried "Fatal" printout the LB failed to run all
the clean-ups (e.g. NSE unregister) during shutdown.
@zolug zolug added kind/bug Something isn't working component/stateless-lb labels Oct 20, 2023
@zolug zolug requested a review from LionelJouin October 24, 2023 08:06
@zolug zolug merged commit 424bb21 into master Nov 6, 2023
@zolug zolug deleted the lb-shutdown branch November 6, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/stateless-lb kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants