Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE; BGP also accepts advertised non-default routes #454

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Conversation

zolug
Copy link
Collaborator

@zolug zolug commented Sep 11, 2023

Description

  • BIRD filters used by the generated BIRD configuration have been updated to accept non-default routes announced by connected BGP peers.

  • Introduced new low prio PBR rule to ensure outbound VIP traffic is not misrouted, i.e. will not be leaked to primary network.
    Blackhole logic is installed by default, but can be configured through frontend env variable DROP_IF_NO_PEER.
    (The related blackhole routes are inserted by BIRD as well.)

  • Updated external-host test tool to either announce default routes (default behavior), or advertise certain pre-defined network routes.

Start external-host to announce non-default routes:
./docs/demo/scripts/kind/external-host.sh --default-route=no

Issue link

#453

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

Filters used by the generated BIRD configuration have been
updated to accept non-default routes announced by connected
BGP peers.

New low prio PBR rule to ensure outbound VIP traffic is not
misrouted. These are setup by default.
(The related blackhole routes are inserted by BIRD as well.)

Updated external-host test tool to either announce default routes
(default behavior), or advertise certain pre-defined network routes.
./docs/demo/scripts/kind/external-host.sh --default-route=no
Copy link
Member

@LionelJouin LionelJouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't fully understood the bird configuration yet, but I understand the concept and tried it, I could run the e2e tests with no problem.

For the kind gateway image, I pushed it to registry.nordix.org/cloud-native/meridio/kind-host:latest

Co-authored-by: Lionel Jouin <LionelJouin@users.noreply.github.com>
@zolug zolug merged commit 95f5e04 into master Sep 18, 2023
@zolug zolug deleted the bgp-no-default branch November 6, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants