TAPA; sync interface name cache for recovered connections #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of a connection recovered through NSM's connection monitor, the so called interface name cache in interfaceNameClient could have become out of sync. That's because the cache was not contacted in such cases, thus upon a faulty Close() or TAPA crash the cache failed to keep track of recovered names. (Which means, such names could be re-used by some other connection.) Therefor, move the interface name of recovered connections from Mechanism to MechanismPreferences, so that intefaceNameClient could handle such connection requests properly. If the inteface name is not yet taken by some other connection, then use it, and also update the inteface name cache if needed. (But generate a new name if already taken by another connection.)
LionelJouin
approved these changes
Aug 22, 2023
|
|
||
| if _, ok := cg.usedNames[name]; ok { | ||
| // already taken | ||
| return os.ErrExist |
There was a problem hiding this comment.
This error will return "file already exists" (https://github.com/golang/go/blob/master/src/os/error.go#L22).
Suggested change
| return os.ErrExist | |
| return fmt.Errorf("name already in use") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #444
In case of a connection recovered through NSM's connection monitor, the so called interface name cache in interfaceNameClient could have become out of sync.
That's because the cache was not contacted in such cases, thus upon a faulty Close() or TAPA crash the cache failed to keep track of recovered names. (Which means, such names could be re-used by some other connection.)
Therefor, move the interface name of recovered connections from Mechanism to MechanismPreferences, so that intefaceNameClient could handle such connection requests properly.
If the inteface name is not yet taken by some other connection, then use it, and also update the inteface name cache if needed. (But generate a new name if already taken by another connection.)
Issue link
Checklist