Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FE; make BIRD use IANA approved ports for BFD (49152-65535) #442

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

zolug
Copy link
Collaborator

@zolug zolug commented Jul 13, 2023

Description

As per BIRD documentation, use ip_local_port_range to force BIRD using IANA approved src ports for BFD.

BFD packets are sent with a dynamic source port number. Linux systems use by default a bit different dynamic port range than the IANA approved one (49152-65535). If you experience problems with compatibility, please adjust /proc/sys/net/ipv4/ip_local_port_range.

Issue link

NA

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

Copy link
Member

@LionelJouin LionelJouin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference for IPv6: https://tldp.org/HOWTO/Linux+IPv6-HOWTO/ch11s03.html

Also, could you update the documentation: https://github.com/Nordix/Meridio/blob/v1.0.9/docs/components/frontend.md?plain=1#L98

Sysctl: net.ipv4.ip_local_port_range='49152 65535' | The source port of BFD Control packets must be in the range 49152-65535

@@ -202,7 +202,7 @@ func (l *LoadBalancer) insertParameters(dep *appsv1.Deployment) *appsv1.Deployme
}
ret.Spec.Template.Spec.InitContainers[0].Args = []string{
"-c",
common.GetLoadBalancerSysCtl(l.trench),
fmt.Sprintf("%s ; %s", common.GetLoadBalancerSysCtl(l.trench), common.GetFrontendSysCtl()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

@zolug zolug Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but I wanted to handle it separately, even though currently LB and FE share the same POD, the settings are FE specific.
There were plans to support a non-composite setups in the future, in which case I figured separating these could help sort things out. If it's not on the TODO list anymore, I can merge them.

edit:
But maybe that component requirement doc is sufficient to track sysctls. So I will do as you suggested.

Adjust /proc/sys/net/ipv4/ip_local_port_range following
recommendation from BIRD.
@zolug zolug force-pushed the ezollug-bfd-port branch from caf010b to 55175d6 Compare July 13, 2023 16:35
@zolug zolug requested a review from LionelJouin July 13, 2023 17:03
@zolug zolug merged commit a743176 into master Jul 14, 2023
@zolug zolug deleted the ezollug-bfd-port branch July 14, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants