Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB; remove replaced interface from interfaces list #433

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

zolug
Copy link
Collaborator

@zolug zolug commented Jun 22, 2023

Description

LB-FE keeps track of interfaces connecting it with proxies. When a proxy interface is replaced, the old interface might linger on, or might not even get removed from the interface list. That's because LB-FE only gets InterfaceDeleted() event upon an NSM connection Close() request. Which might happen with severe delay (MaxTokenLifetime expiration), or might not even happen if the Close fails (does not reach LB-FE's interfacemonitor server chain). Either way, it leads to unnecessary and confusing excess work and printouts where LB-FE tries to set the old interface's state to Down again and again.

So let's remove the old interface from the interface list when the interface replace event is first noticed.

Issue link

NA

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

@zolug zolug merged commit e83dc00 into master Jun 26, 2023
@zolug zolug deleted the ezollug-lb-disable branch July 10, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants