Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match flow metrics collection #428

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Match flow metrics collection #428

merged 4 commits into from
Oct 19, 2023

Conversation

LionelJouin
Copy link
Member

@LionelJouin LionelJouin commented Jun 12, 2023

Description

Add metrics documentation
Update dependencies with latest otpl version
Collect flow match count from nfqlb and register it with a async counter (open telemtry) instrument
Init of the metrics in the stateless-lb via a https server exporting metrics via prometheus protocol.

Issue link

#419

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

@LionelJouin LionelJouin marked this pull request as draft June 12, 2023 13:16
@LionelJouin LionelJouin force-pushed the observability branch 4 times, most recently from 998bfca to d59f490 Compare June 15, 2023 15:54
@LionelJouin LionelJouin marked this pull request as ready for review June 20, 2023 13:46
@LionelJouin LionelJouin requested a review from zolug June 20, 2023 13:46
@LionelJouin LionelJouin marked this pull request as draft June 22, 2023 09:12
@LionelJouin LionelJouin marked this pull request as ready for review June 26, 2023 09:33
@LionelJouin LionelJouin marked this pull request as draft September 18, 2023 09:22
@LionelJouin LionelJouin force-pushed the observability branch 3 times, most recently from 6008af5 to 7de90da Compare September 22, 2023 08:10
@LionelJouin LionelJouin force-pushed the observability branch 2 times, most recently from 24110e4 to 082a255 Compare October 9, 2023 14:17
@LionelJouin LionelJouin marked this pull request as ready for review October 9, 2023 14:46
@LionelJouin LionelJouin changed the title Match flow metrics collection with OPTL Match flow metrics collection Oct 9, 2023
@LionelJouin LionelJouin force-pushed the observability branch 5 times, most recently from e69beb8 to 94cf1d9 Compare October 12, 2023 12:39
Add metrics documentation
Update dependencies with latest otpl version
Init of the open telemetry collector in the stateless-lb
Collect flow match count from nfqlb and register it to otpl with a
counter instrument
Deployment example for Open Telemetry, Prometheus and Grafana.
Disable open telemetry collector by default.
Fix deployment
Add demo instructions
@LionelJouin LionelJouin force-pushed the observability branch 3 times, most recently from e107e8f to 1dc589a Compare October 18, 2023 13:09
Rename pkg metric to metrics.
Use observable counter instead of a counter since observable instrument
is more adapted for this case according to the open telemetry
documentation.
otpl exporter replaced by the prometheus via a http server.
Open Telemetry has to be updated to fix bugs related to temporality of
the metrics.
@LionelJouin LionelJouin merged commit 2e277c7 into master Oct 19, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants