Adjust rpc-timeout of gRPC probes #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RPC timeout value defaults to 1s in case of SPIFFE issued credentials.
Using SPIFFE Workload API to retrive TLS credentials can be CPU intensive. Can result in increased probe response times and thus failed probes. - GRPC_PROBE_RPC_TIMEOUT operator env variable (defaults to 1s) - 2s liveness probe init delay (avoid overlap with readiness probe) - RPC timeout of other gRPC probes relying on SPIFFE increased (1s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using SPIFFE Workload API to retrieve TLS credentials can be CPU intensive. Thus, employing resource limits for Spire can lead to failed probes.
Set default rpc-timeout of grpc-health-probes in case of SPIFFE issued credentials to 1s.
Also, use 2 seconds initial delay for liveness probes not to overlap with readiness probes.
RPC timeout of code internal grpc-health-probes can be adjusted via
GRPC_PROBE_RPC_TIMEOUToperator environment variable (expects time.Duration values).Issue link
#420
Checklist