Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy IP release non blocking #412

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Proxy IP release non blocking #412

merged 1 commit into from
Apr 28, 2023

Conversation

LionelJouin
Copy link
Member

@LionelJouin LionelJouin commented Apr 25, 2023

Description

Releasing the IPs in the proxy is now no longer blocking and is handled by a separate go routine, that will also retry if releasing IPs fails.

Issue link

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No

Releasing the IPs in the proxy is now no longer blocking and is handled
by a separate go routine, that will also retry if releasing IPs fails.
@LionelJouin LionelJouin force-pushed the proxy-ip-release-fix-2 branch from c6c276e to b325d30 Compare April 27, 2023 12:02
@LionelJouin LionelJouin requested a review from zolug April 28, 2023 07:25
Copy link
Collaborator

@zolug zolug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants