Stateless-lb: Disable old interfaces with same subnet as new

[uablrek]

Description

When a new interface is detected any existing interface with the same subnet is disabled

Issue link

#392

Checklist

• Purpose
  • Bug fix
  • New functionality
  • Documentation
  • Refactoring
  • CI
• Test
  • Unit test
  • E2E Test
  • Tested manually
• Introduce a breaking change
  • Yes (description required)
  • No

[uablrek]

Log:

{
  "severity": "info",
  "timestamp": "2023-04-19T07:19:24.99+00:00",
  "service_id": "Meridio-LB",
  "message": "Interface replaced",
  "version": "1.0.0",
  "extra_data": {
    "class": "SimpleNetworkService",
    "old": {
      "Name": "load-balan-4fa1",
      "LocalIPs": [
        "172.17.4.4/24",
        "fd00::ac11:404/120"
      ],
      "NeighborIPs": [
        "172.17.4.5/24",
        "fd00::ac11:405/120"
      ],
      "Gateways": null,
      "InterfaceType": 0
    },
    "new": {
      "Name": "load-balan-5d5e",
      "LocalIPs": [
        "172.17.4.10/24",
        "fd00::ac11:40a/120"
      ],
      "NeighborIPs": [
        "172.17.4.11/24",
        "fd00::ac11:40b/120"
      ],
      "Gateways": null,
      "InterfaceType": 0
    }
  }
}

This appears multiple time for some reason. In my 5-node xcluster it appears 12 times on a node reboot

[uablrek]

Log commands:

kubectl logs -c stateless-lb ... | jq 'select(.message == "Interface replaced")'
kubectl logs -c stateless-lb ... | jq .message | grep 'Interface replaced' | wc -l

[LionelJouin]

Tested, it works (but should be fixed in NSM, not Meridio)

[uablrek]

Tested, it works (but should be fixed in NSM, not Meridio)

Right 😒 Should I merge anyway?

[zolug]

Works for me as well.
IMHO we should merge it.