Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSM uplift to v1.6.0 #293

Merged
merged 1 commit into from
Oct 6, 2022
Merged

NSM uplift to v1.6.0 #293

merged 1 commit into from
Oct 6, 2022

Conversation

LionelJouin
Copy link
Member

@LionelJouin LionelJouin commented Sep 20, 2022

Description

https://github.com/networkservicemesh/api/releases/tag/v1.6.0
https://github.com/networkservicemesh/sdk/releases/tag/v1.6.0
https://github.com/networkservicemesh/sdk-sriov/releases/tag/v1.6.0

cmd-nsc:v1.6.0 and cmd-nse-remote-vlan:v1.6.0 are on the Nordix registry.
cmd-nse-remote-vlan:v1.6.0 is compiled from this source (to include grpc-health-probe): https://github.com/Nordix/nsm-cmd-nse-remote-vlan/tree/probes-1.6.0

I had to add replace cloud.google.com/go => cloud.google.com/go v0.104.0 at the end of the go.mod, otherwise I was getting this error:

lionelj@lionel-EST-Precision:~/Workspaces/Meridio$ go mod tidy
github.com/nordix/meridio/pkg/endpoint imports
        github.com/networkservicemesh/sdk/pkg/tools/tracing imports
        go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc tested by
        go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.test imports
        google.golang.org/grpc/interop imports
        golang.org/x/oauth2/google imports
        cloud.google.com/go/compute/metadata: ambiguous import: found package cloud.google.com/go/compute/metadata in multiple modules:
        cloud.google.com/go v0.97.0 (/home/lionelj/go/pkg/mod/cloud.google.com/go@v0.97.0/compute/metadata)
        cloud.google.com/go/compute v1.7.0 (/home/lionelj/go/pkg/mod/cloud.google.com/go/compute@v1.7.0/metadata)

Issue link

/

Checklist

  • Purpose
    • Bug fix
    • New functionality
    • Documentation
    • Refactoring
    • CI
  • Test
    • Unit test
    • E2E Test
    • Tested manually
  • Introduce a breaking change
    • Yes (description required)
    • No
  • Introduce changes in the Operator
    • Yes (description required)
    • No

@LionelJouin LionelJouin added the kind/enhancement New feature or request label Sep 20, 2022
@LionelJouin LionelJouin changed the title NSM uplift to v1.6.0-rc.1 NSM uplift to v1.6.0 Oct 4, 2022
@LionelJouin LionelJouin requested review from zolug and uablrek October 4, 2022 08:36
@LionelJouin LionelJouin marked this pull request as ready for review October 4, 2022 08:37
@uablrek
Copy link
Contributor

uablrek commented Oct 4, 2022

Remove the rc1 commit and update deployments/helm/values.yaml

@LionelJouin
Copy link
Member Author

I removed the rc1 commit but what would you like me to update in deployments/helm/values.yaml?

@uablrek
Copy link
Contributor

uablrek commented Oct 4, 2022

# grep -rF v1.5 deployments/
deployments/helm/values.yaml:  version: v1.5.0
deployments/helm/values.yaml:  version: v1.5.0

@LionelJouin LionelJouin merged commit 5ae8abf into master Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants